feat: App Profile multi cluster routing support with specified cluster ids #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r ids Add the `multi_cluster_ids` parameter to AppProfile. It is used when the routing policy type is set to "any". Add tests, docstrings. Fix some typos. Closes internal issue 213627978
product-auto-label
bot
added
the
api: bigtable
parthea
approved these changes
Apr 4, 2022
kolea2
requested changes
Apr 13, 2022
| @@ -87,6 +91,7 @@ def _modify_app_profile_helper( | |||
| assert alt_profile.description == description | |||
| assert alt_profile.routing_policy_type == routing_policy_type | |||
| assert alt_profile.cluster_id == cluster_id | |||
| assert alt_profile.multi_cluster_ids == multi_cluster_ids | |||
There was a problem hiding this comment.
can we add a few more system tests that create an app profile with multi cluster routing and ids specified, and also an update test adding or removing a cluster id?
There was a problem hiding this comment.
I've added the test below: test_instance_create_app_profile_create_with_multi_cluster_ids
kolea2
approved these changes
Apr 14, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
multi_cluster_idsparameter to AppProfile.It is used when the routing policy type is set to "any".
Add tests, docstrings.
Fix some typos.
Closes internal issue 213627978
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #213627978 🦕