Asynchronous batching #702
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call the async mutate_rows from grpc aio Create flush and mutate_coroutines
product-auto-label
bot
added
size: m
Mariatta
commented
Nov 30, 2022
| @@ -526,7 +526,7 @@ async def mutate_row( | |||
| # Done; return the response. | |||
| return response | |||
|
|
|||
| def mutate_rows( | |||
| async def mutate_rows( | |||
There was a problem hiding this comment.
This needs to be fixed in gapic generator.
Related PR: googleapis/gapic-generator-python#1502
|
Closed in favor of #722 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call the async mutate_rows from grpc aio
Create flush and mutate_coroutines
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 馃