Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review exception structure #794

Closed
daniel-sanche opened this issue Jun 5, 2023 · 0 comments
Closed

Review exception structure #794

daniel-sanche opened this issue Jun 5, 2023 · 0 comments
Assignees
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Milestone

Comments

@daniel-sanche
Copy link
Contributor

daniel-sanche commented Jun 5, 2023

For the v3 client, we use exception groups to group a sequence of retry exceptions, and also to group exceptions related to a bulk operation. In some cases, these groups can be nested, with retry groups inside of bulk operation exception groups.

We should review how we want to expose this, to make sure handling exceptions is user-friendly, and root causes are easy to determine.

Discussion here: #769 (comment)


We also have to make sure our exceptions follow the actionable error conventions, and that error details are properly exposed in error messages


ExceptionGroups should print some (or all) of the sub-exceptions for debugging, even on < 3.11

@daniel-sanche daniel-sanche added type: cleanup An internal cleanup or hygiene concern. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Jun 5, 2023
@daniel-sanche daniel-sanche added this to the v3 milestone Jun 5, 2023
@daniel-sanche daniel-sanche self-assigned this Jun 5, 2023
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Jun 5, 2023
@daniel-sanche daniel-sanche modified the milestones: v3-alpha, v3-beta Jun 29, 2023
@daniel-sanche daniel-sanche modified the milestones: v3-beta, v3-alpha Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

1 participant