Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: require google-cloud-core 1.4.4 #866

Merged
merged 3 commits into from Sep 20, 2023
Merged

fix: require google-cloud-core 1.4.4 #866

merged 3 commits into from Sep 20, 2023

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Sep 19, 2023

The dependency six was added in google-cloud-core==1.4.4 . The google-cloud-core==1.4.1 doesn't declare the dependency on six.

python-bigtable/setup.py

Line 41 in 4105df7

"google-cloud-core >= 1.4.1, <3.0.0dev",

Fixes #864 馃

@parthea parthea requested review from a team as code owners September 19, 2023 15:39
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/python-bigtable API. labels Sep 19, 2023
@parthea parthea requested a review from a team as a code owner September 19, 2023 16:53
@parthea parthea merged commit 09f8a46 into main Sep 20, 2023
26 of 27 checks passed
@parthea parthea deleted the update-google-cloud-core branch September 20, 2023 00:59
@release-please release-please bot mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-sanche daniel-sanche daniel-sanche approved these changes

@balajismaniam balajismaniam Awaiting requested review from balajismaniam balajismaniam is a code owner automatically assigned from googleapis/python-samples-reviewers

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The build failed
2 participants
@parthea @daniel-sanche