Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass kwargs through in 'from_service_account_json' #109

Merged
merged 2 commits into from
Jun 25, 2021
Merged

fix: pass kwargs through in 'from_service_account_json' #109

merged 2 commits into from
Jun 25, 2021

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 24, 2021

Also, pin 'googleapis-common-protos' for Python 2.7 tests.

Closes #108.

@tseaver
fix: pass kwargs through in 'from_service_account_json'
6fd373b 
Also, pin 'googleapis-common-protos' for Python 2.7 tests.

Closes #108.
@tseaver tseaver requested a review from busunkim96 June 24, 2021 17:18
@tseaver tseaver requested a review from a team as a code owner June 24, 2021 17:18
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 24, 2021
@tseaver tseaver mentioned this pull request Jun 24, 2021
Closed
busunkim96
busunkim96 approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

chrisrossi
chrisrossi suggested changes Jun 24, 2021
View reviewed changes
google/cloud/client.py Outdated Show resolved Hide resolved
@tseaver tseaver requested a review from chrisrossi June 24, 2021 22:29
chrisrossi
chrisrossi approved these changes Jun 25, 2021
View reviewed changes
Copy link

@chrisrossi chrisrossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tseaver tseaver merged commit efc4bbf into master Jun 25, 2021
@tseaver tseaver deleted the 108-project-arg-to-from_service_account_json branch June 25, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisrossi chrisrossi chrisrossi approved these changes

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

project kwarg ignored when from_service_account_json is used
3 participants
@tseaver @chrisrossi @busunkim96