Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct param type of _ClientFactoryMixin.from_service_account_info method #161

Merged
merged 1 commit into from
Nov 16, 2021
Merged

fix: correct param type of _ClientFactoryMixin.from_service_account_info method #161

merged 1 commit into from
Nov 16, 2021
+1 −1

Conversation

yukihira1992
Copy link
Contributor

@yukihira1992 yukihira1992 commented Nov 16, 2021 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #162 🦕

@yukihira1992 yukihira1992 requested a review from a team as a code owner November 16, 2021 09:22
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 16, 2021
@yukihira1992
Copy link
Contributor Author

It seems that the info param type is wrong.
bigquery.Client.from_service_account_info method passes the info param to service_account.Credentials.from_service_account_info method.
service_account.Credentials.from_service_account_info method requires Mapping[str, str] type.
This method raises AttributeError if I pass a json string as info.

AttributeError: 'str' object has no attribute 'keys'

busunkim96
busunkim96 approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yukihira1992!

@busunkim96 busunkim96 added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 16, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 24b7de4 into googleapis:main Nov 16, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 16, 2021
@yukihira1992 yukihira1992 deleted the fix/type-info branch November 17, 2021 15:20
@release-please release-please bot mentioned this pull request Jan 13, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jan 18, 2022
@release-please
chore(main): release 2.2.2 (#169)
1630cac 
🤖 I have created a release *beep* *boop*
---


### [2.2.2](v2.2.1...v2.2.2) (2022-01-17)


### Bug Fixes

* correct param type of _ClientFactoryMixin.from_service_account_info method ([#161](#161)) ([24b7de4](24b7de4))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

param type of _ClientFactoryMixin.from_service_account_info method is wrong
3 participants
@yukihira1992 @busunkim96 @yoshi-kokoro