Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

docs(samples): Adding a missing region tag #300

Merged
merged 2 commits into from
Jul 1, 2022

Conversation

m-strzelczyk
Copy link
Contributor

Turns out I missed the compute_create_windows_instance_external_ip region tag when I first made those samples. Adding it now.

@m-strzelczyk m-strzelczyk requested review from a team as code owners June 27, 2022 13:19
@m-strzelczyk m-strzelczyk requested a review from nicain June 27, 2022 13:19
@snippet-bot
Copy link

snippet-bot bot commented Jun 27, 2022

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: compute Issues related to the googleapis/python-compute API. samples Issues that are directly related to samples. labels Jun 27, 2022
@@ -19,6 +19,7 @@
# directory and apply your changes there.


# [START compute_create_windows_instance_external_ip]
# [START compute_create_windows_instance_internal_ip]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2nd region start tag is redundant and should be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I want this sample to show up in the sample browser, and those two tags are different. In other languages we have different samples for external and internal, but due to the way Python samples are created, it's pointless to create a whole new sample just to change one boolean variable, so I want this to have a START for two different regions.

@m-strzelczyk m-strzelczyk merged commit e402750 into main Jul 1, 2022
@m-strzelczyk m-strzelczyk deleted the samples-external-windows branch July 1, 2022 12:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: compute Issues related to the googleapis/python-compute API. samples Issues that are directly related to samples. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants