Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

fix: test cleanup stages with try finally #212

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Conversation

Shabirmean
Copy link
Member

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #210 馃

  • Surround the cleanup step with try-finally to ensure cleanup of clusters regardless of test state

@Shabirmean Shabirmean requested review from a team as code owners March 21, 2022 23:03
@product-auto-label product-auto-label bot added the api: container Issues related to the googleapis/python-container API. label Mar 21, 2022
@Shabirmean Shabirmean merged commit 529bcbf into main Mar 22, 2022
@Shabirmean Shabirmean deleted the fix/test-cleanup branch March 22, 2022 01:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: container Issues related to the googleapis/python-container API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GKE clusters not cleaning up after create cluster test
2 participants