docs(samples): add Agent Assist code samples #267

rogers140 · 2021-03-22T18:48:09Z

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

snippet-bot · 2021-03-22T18:48:17Z

Here is the summary of changes.

You are about to add 16 region tags.

samples/snippets/answer_record_management.py:22, tag dialogflow_update_answer_record
samples/snippets/conversation_management.py:22, tag dialogflow_create_conversation
samples/snippets/conversation_management.py:51, tag dialogflow_get_conversation
samples/snippets/conversation_management.py:74, tag dialogflow_complete_conversation
samples/snippets/conversation_profile_management.py:22, tag dialogflow_list_conversation_profiles
samples/snippets/conversation_profile_management.py:40, tag dialogflow_create_conversation_profile_article_faq
samples/snippets/conversation_profile_management.py:124, tag dialogflow_create_conversation_profile_smart_reply
samples/snippets/conversation_profile_management.py:183, tag dialogflow_get_conversation_profile
samples/snippets/conversation_profile_management.py:205, tag dialogflow_delete_conversation_profile
samples/snippets/document_management.py:42, tag dialogflow_list_document
samples/snippets/document_management.py:110, tag dialogflow_get_document
samples/snippets/document_management.py:136, tag dialogflow_delete_document
samples/snippets/knowledge_base_management.py:59, tag dialogflow_get_knowledge_base
samples/snippets/knowledge_base_management.py:80, tag dialogflow_delete_knowledge_base
samples/snippets/participant_management.py:24, tag dialogflow_create_participant
samples/snippets/participant_management.py:49, tag dialogflow_analyze_content_text

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

engelke · 2021-03-22T19:45:33Z

This is a very big PR, well over 1000 lines of new code. It's going to be a while before I can get the time to review it.

rogers140 · 2021-03-22T21:21:30Z

This is a very big PR, well over 1000 lines of new code. It's going to be a while before I can get the time to review it.

Sorry about that. We are actually just migrating private code samples to public for Agent Assist Public Preview Launch. If there is a better way to do this, please let me know.

engelke

Pass lint and all tests.
Make sure all functions have tests.
Update copyright dates if anything has been written or first published this year.
Have white space before and after import statements and internally to break code into logical chunks for readability.
Use \n in print statements only when double spacing is needed, and use consistently.

engelke · 2021-03-23T18:34:38Z

samples/snippets/analyze_content_text_test.py

@@ -0,0 +1,144 @@
+# Copyright 2019 Google LLC


If this is newly published, use 2021 for copyright.

engelke · 2021-03-23T18:47:34Z

samples/snippets/answer_record_management.py

@@ -0,0 +1,46 @@
+#!/usr/bin/env python
+
+# Copyright 2019 Google LLC


Same copyright note

engelke · 2021-03-23T18:48:33Z

samples/snippets/answer_record_management.py

+
+
+# [START dialogflow_update_answer_record]
+def update_anwer_record(project_id, answer_record_id, click):


Is this a typo, or is there a reason not call this update_answer_record?

engelke · 2021-03-23T18:49:14Z

samples/snippets/answer_record_management.py

+def update_anwer_record(project_id, answer_record_id, click):
+    """Update the answer record.
+
+    Args:


What is the "click" argument for?

Added comments.

engelke · 2021-03-23T18:49:36Z

samples/snippets/answer_record_management.py

+        project_id: The GCP project linked with the conversation profile.
+        answer_record_id: The answer record id returned along with the
+        suggestion."""
+    from google.cloud import dialogflow_v2 as dialogflow


Add leading whitespace

engelke · 2021-03-23T20:43:24Z

samples/snippets/extended_streaming.py

+
+Also please contact Google to get credentials of this project and set up the
+credential file json locations by running:
+export GOOGLE_APPLICATION_CREDENTIALS=<cred_json_file_location>


There are other environment variables the program expects. If we include these steps (above) we should include them, too.

engelke · 2021-03-23T20:47:51Z

samples/snippets/extended_streaming.py

@@ -0,0 +1,229 @@
+# Copyright 2019 Google LLC


Is there a test for this code? I don't see one.

engelke · 2021-03-23T20:54:26Z

samples/snippets/knowledge_base_management.py

 """

 import argparse


+# [START dialogflow_list_knowledge_base]


Are there tests for each method? Where are they?

Removed this function.

engelke · 2021-03-23T20:59:58Z

samples/snippets/participant_management.py

+    print('Reply Text: {}'.format(response.reply_text))
+
+    for suggestion_result in response.human_agent_suggestion_results:
+        if suggestion_result.error is None:


I think this should be is not None, instead of is None. Otherwise the next line will have an exception.

engelke · 2021-03-23T21:01:19Z

samples/snippets/participant_management.py

+    Args:
+        participant_name: resource name of the participant.
+        sample_rate_herz: herz rate of the sample.
+        audio_generator: a sequence of audio data.


This doesn't match the argument list above.

rogers140 · 2021-03-23T23:39:28Z

Pass lint and all tests.
Make sure all functions have tests.
Update copyright dates if anything has been written or first published this year.
Have white space before and after import statements and internally to break code into logical chunks for readability.
Use \n in print statements only when double spacing is needed, and use consistently.

Fixed the issue you mentioned and better organized the tests. Removed some unnecessary functions and samples.

Ran pytest . under the samples/snippets and all of them passed.

I think I don't know how to update the readme.rst, it seems autogenerated by readme.in but I don't know how it works. Do you know?

…E_CLOUD_PROJECT`.

🤖 I have created a release \*beep\* \*boop\* --- ### [2.1.1](https://www.github.com/googleapis/python-dialogflow/compare/v2.1.0...v2.1.1) (2021-04-12) ### Bug Fixes * remove `input_audio` field from AnalyzeContentRequest from v2/v2beta1 ([06381fc](https://www.github.com/googleapis/python-dialogflow/commit/06381fcc965669e1b3dc8bec22aa567dceb6f935)) * remove proto message CreateCallMatcherRequest, CreateCallMatcherResponse, ListCallMatchersRequest, ListCallMatchersResponse, DeleteCallMatcherRequest, DeleteCallMatcherResponse, CallMatcher, StreamingAnalyzeContentRequest, StreamingAnalyzeContentResponse, AudioInput from v2/v2beta1, TelephonyDtmfEvents, TelephonyDtmf from v2 ([06381fc](https://www.github.com/googleapis/python-dialogflow/commit/06381fcc965669e1b3dc8bec22aa567dceb6f935)) * remove resource_reference for invisible resources ([06381fc](https://www.github.com/googleapis/python-dialogflow/commit/06381fcc965669e1b3dc8bec22aa567dceb6f935)) * Remove resource_reference from UpdateAnswerRecord ([06381fc](https://www.github.com/googleapis/python-dialogflow/commit/06381fcc965669e1b3dc8bec22aa567dceb6f935)) * remove rpc or fields that are unintended to release ([#264](https://www.github.com/googleapis/python-dialogflow/issues/264)) ([06381fc](https://www.github.com/googleapis/python-dialogflow/commit/06381fcc965669e1b3dc8bec22aa567dceb6f935)) * remove StreamingAnalyzeContent, CreateCallMatcher, ListCallMatchers, DeleteCallMatcher rpc from v2/v2beta1 ([06381fc](https://www.github.com/googleapis/python-dialogflow/commit/06381fcc965669e1b3dc8bec22aa567dceb6f935)) ### Documentation * **samples:** add Agent Assist code samples ([#267](https://www.github.com/googleapis/python-dialogflow/issues/267)) ([0a8cfb9](https://www.github.com/googleapis/python-dialogflow/commit/0a8cfb9ac71870df9f69ae518e32a920d08bd170)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Add Agent Assist code samples.

3ccf2d2

rogers140 requested a review from a team as a code owner March 22, 2021 18:48

rogers140 requested review from engelke and removed request for a team March 22, 2021 18:48

google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 22, 2021

product-auto-label bot added api: dialogflow Issues related to the googleapis/python-dialogflow API. samples Issues that are directly related to samples. labels Mar 22, 2021

Ruogu Liu added 4 commits March 22, 2021 11:56

Add Agent Assist code samples.

cb18941

Merge branch 'master' of github.com:rogers140/python-dialogflow

6815c22

Fix the method prefix.

90b4a4f

Fix more region tag issues.

6940e59

rogers140 changed the title ~~Add Agent Assist code samples.~~ add Agent Assist code samples. Mar 22, 2021

rogers140 changed the title ~~add Agent Assist code samples.~~ feat(support): add Agent Assist code samples. Mar 22, 2021

rogers140 changed the title ~~feat(support): add Agent Assist code samples.~~ feat(support): add Agent Assist code samples Mar 22, 2021

engelke added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 22, 2021

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 22, 2021

Fix issues with python style.

59aaa43

engelke added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 23, 2021

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 23, 2021

engelke suggested changes Mar 23, 2021

View reviewed changes

Ruogu Liu added 3 commits March 23, 2021 16:17

Merge branch 'master' of https://github.com/googleapis/python-dialogflow

6d1f6c8

Removed audio-streaming related samples of ccai and added tests.

9c58c7a

Remove list_knowledge_bases function as we don't need it.

237c5f4

rogers140 requested a review from engelke March 24, 2021 22:07

engelke added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 24, 2021

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 24, 2021

Ruogu Liu added 2 commits March 24, 2021 15:33

Fix lint error.

6e72086

Fix the import order of create_document_test.py.

f810ef9

engelke added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 24, 2021

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 24, 2021

Fix more lint error.

fc1a793

engelke assigned engelke and unassigned engelke Mar 25, 2021

engelke added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2021

yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 25, 2021

Fix lint error.

50733f2

engelke added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2021

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2021

Change the usage in sample code from using GCLOUD_PROJECT to `GOOGL…

f893616

…E_CLOUD_PROJECT`.

busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2021

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2021

engelke approved these changes Mar 25, 2021

View reviewed changes

busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2021

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2021

busunkim96 changed the title ~~feat(support): add Agent Assist code samples~~ docs(samples): add Agent Assist code samples Mar 25, 2021

busunkim96 merged commit 0a8cfb9 into googleapis:master Mar 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs(samples): add Agent Assist code samples #267

docs(samples): add Agent Assist code samples #267

rogers140 commented Mar 22, 2021 •

edited

Loading

snippet-bot bot commented Mar 22, 2021 •

edited

Loading

engelke commented Mar 22, 2021

rogers140 commented Mar 22, 2021

engelke left a comment

engelke Mar 23, 2021

rogers140 Mar 23, 2021

engelke Mar 23, 2021

rogers140 Mar 23, 2021

engelke Mar 23, 2021

rogers140 Mar 23, 2021

engelke Mar 23, 2021

rogers140 Mar 23, 2021

engelke Mar 23, 2021

rogers140 Mar 23, 2021

engelke Mar 23, 2021

engelke Mar 23, 2021

engelke Mar 23, 2021

rogers140 Mar 23, 2021

engelke Mar 23, 2021

rogers140 Mar 23, 2021

engelke Mar 23, 2021

rogers140 Mar 23, 2021

rogers140 commented Mar 23, 2021 •

edited

Loading

		@@ -0,0 +1,46 @@
		#!/usr/bin/env python

		# Copyright 2019 Google LLC



		# [START dialogflow_update_answer_record]
		def update_anwer_record(project_id, answer_record_id, click):

docs(samples): add Agent Assist code samples #267

docs(samples): add Agent Assist code samples #267

Conversation

rogers140 commented Mar 22, 2021 • edited Loading

snippet-bot bot commented Mar 22, 2021 • edited Loading

engelke commented Mar 22, 2021

rogers140 commented Mar 22, 2021

engelke left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rogers140 commented Mar 23, 2021 • edited Loading

rogers140 commented Mar 22, 2021 •

edited

Loading

snippet-bot bot commented Mar 22, 2021 •

edited

Loading

rogers140 commented Mar 23, 2021 •

edited

Loading