Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added client_info to storage client #10

Merged
merged 34 commits into from
Oct 27, 2022
Merged

feat: added client_info to storage client #10

merged 34 commits into from
Oct 27, 2022

Conversation

galz10
Copy link
Collaborator

@galz10 galz10 commented Oct 11, 2022 •
edited by parthea
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 馃

BEGIN_COMMIT_OVERRIDE
chore: Set initial version to 0.1.0-alpha

Release-As: 0.1.0-alpha
END_COMMIT_OVERRIDE

@galz10
feat: add get_document and list_document functions
d141a67
@galz10
fixed tests
1de3f02
@galz10
lint fix
1b9324f
@galz10
added tests and changed DocumentWrapper
446e187
@galz10
fixed failing test
ed86e84
@galz10
updated tests
9fc848b
@galz10
changed DocStrings and tests
88001da
@galz10
fixed failing test
1090173
@galz10
changed name and return type of list_documents
0cec6b5
@galz10
updated failing tests
0b67124
@galz10
lint fix
01e551f
@galz10
chore: updated comments
c25faf3
@galz10
updating naming for get_document to get_shards
cf8abef
@galz10
revert get_document changes
a8bbf7a
@galz10
Merge branch 'main' into update_comments
3c547e0
@galz10
lint fix
8df5b0b
@galz10
added code-block to comments
6ac3b43
@galz10
feat: add TableWrapper and helper functions
0b1b52a
@galz10
wrapped lines and paragraphs
fb81212
@galz10
Merge branch 'main' into wrap-table
eaabc42
@galz10
Merge branch 'main' into wrap-table
efc302f
@galz10
added tests for new features
88bbe01
@galz10
lint fix
f7ede09
@galz10
chore: added client_info to storage client
e42229d
@galz10 galz10 requested a review from a team as a code owner October 11, 2022 18:11
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Oct 11, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Oct 18, 2022
@galz10 galz10 requested a review from dizcology October 21, 2022 17:42
dizcology
dizcology approved these changes Oct 27, 2022
View reviewed changes
Copy link
Collaborator

@dizcology dizcology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments about imports.

google/cloud/documentai_toolbox/wrappers/document.py Outdated Show resolved Hide resolved
google/cloud/documentai_toolbox/wrappers/document.py Show resolved Hide resolved
@dizcology
Copy link
Collaborator

This may be a bit of a borderline case, but this PR probably could be considered a feat instead of a chore?

@galz10 galz10 changed the title chore: added client_info to storage client feat: added client_info to storage client Oct 27, 2022
@galz10 galz10 merged commit b01c38b into main Oct 27, 2022
@galz10 galz10 deleted the analytics branch October 27, 2022 21:29
@release-please release-please bot mentioned this pull request Oct 27, 2022
Closed
@release-please release-please bot mentioned this pull request Dec 6, 2022
Merged
@parthea parthea added the release-please:force-run To run release-please label Dec 6, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Dec 6, 2022
@parthea parthea added the release-please:force-run To run release-please label Dec 6, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Dec 6, 2022
@parthea parthea added the release-please:force-run To run release-please label Dec 6, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Dec 6, 2022
@parthea parthea added the release-please:force-run To run release-please label Dec 6, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankyn frankyn frankyn approved these changes

@dizcology dizcology dizcology approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@galz10 @dizcology @frankyn @parthea