Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change ocr_line <span> to include all ocr_word #169

Merged
merged 5 commits into from Oct 3, 2023

Conversation

ralscha
Copy link
Contributor

@ralscha ralscha commented Sep 23, 2023

Fixes the xml for ocr_line. The span of ocr_line should enclose all spans of ocr_word

@ralscha ralscha requested review from a team as code owners September 23, 2023 15:02
@google-cla
Copy link

google-cla bot commented Sep 23, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Sep 23, 2023
@holtskinner holtskinner added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 25, 2023
@holtskinner
Copy link
Member

@holtskinner holtskinner changed the title Fix ocr_line span fix: Change ocr_line <span> to include all ocr_word Sep 28, 2023
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Sep 28, 2023
@holtskinner holtskinner added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 28, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 28, 2023
@holtskinner
Copy link
Member

holtskinner commented Sep 28, 2023

I updated the test data and fixed the PR message for you.

@ralscha I just need you to fill out the Google Contributor License Agreement (CLA) to get this merged. https://cla.developers.google.com/

@holtskinner holtskinner added the automerge Merge the pull request once unit tests and other checks pass. label Sep 28, 2023
@holtskinner holtskinner added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 28, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 28, 2023
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 28, 2023
@holtskinner holtskinner added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 3, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 3, 2023
@holtskinner holtskinner added kokoro:run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Oct 3, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 3, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit bc44dab into googleapis:main Oct 3, 2023
15 of 18 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 3, 2023
holtskinner added a commit that referenced this pull request Oct 3, 2023
- Should resolve customer reported issue in support case #47169701 relating to duplicate/inaccurate elements in hOCR output
- Followup to:
  - #161
  - #169
holtskinner added a commit that referenced this pull request Oct 3, 2023
- Should resolve customer reported issue in support case #47169701 relating to duplicate/inaccurate elements in hOCR output
- Followup to:
  - #161
  - #169
holtskinner added a commit that referenced this pull request Oct 6, 2023
* fix: `docai_utilities.py` to return `Optional`

- Should resolve customer reported issue in support case #47169701 relating to duplicate/inaccurate elements in hOCR output
- Followup to:
  - #161
  - #169

* Increase test coverage

* Addressed review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants