fix: Empty Page SubElements #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
holtskinner
commented
Oct 20, 2023
•
holtskinner
commented
- Changed page elements to be initalized with document text instead of page text.
- Caused all paragraphs/blocks/etc after the first page to be empty.
- Introduced in feat: added hOCR export functionality #123
- https://github.com/googleapis/python-documentai-toolbox/pull/123/files#diff-af92c6de8f8e84ca66d2fb9fa7e9bddb5bd644e944153bf7a78d35f47c05853eR251
- Added new Unit test which covers the issue
- Discovered in QA DocAI can't work because of NaN's (and little update request) GoogleCloudPlatform/generative-ai#217
|
This issue could have also been part of the reason for #160 |
- Changed page elements to be initalized with document text instead of page text. - Caused all paragraphs/blocks/etc after the first page to be empty. - Introduced in #123 - https://github.com/googleapis/python-documentai-toolbox/pull/123/files#diff-af92c6de8f8e84ca66d2fb9fa7e9bddb5bd644e944153bf7a78d35f47c05853eR251
dizcology
approved these changes
Oct 23, 2023
holtskinner
added
automerge
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:run
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.