Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): require google-api-core>=1.31.5, >=2.3.2 #543

Merged
merged 3 commits into from Mar 4, 2022
Merged

fix(deps): require google-api-core>=1.31.5, >=2.3.2 #543

merged 3 commits into from Mar 4, 2022

Conversation

Mariatta
Copy link
Contributor

@Mariatta Mariatta commented Mar 2, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 馃

@Mariatta Mariatta requested review from a team as code owners March 2, 2022 23:50
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Mar 2, 2022
parthea
parthea requested changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you also bump the minimum 2.x version?
For example, see 7a465cb

@Mariatta
Copy link
Contributor Author

Mariatta commented Mar 3, 2022

Thanks. Updated.

@Mariatta Mariatta requested a review from parthea March 3, 2022 16:06
@parthea parthea changed the title chore: Bump minimum version of google-api-core fix(deps): require google-api-core>=1.31.5, >=2.3.2 Mar 4, 2022
@parthea parthea merged commit c214732 into main Mar 4, 2022
@parthea parthea deleted the bump-google-api-core branch March 4, 2022 01:07
@release-please release-please bot mentioned this pull request Mar 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/python-firestore API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mariatta @parthea