Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): require google-api-core >= 1.31.5, >= 2.3.2 on v1 release #550

Merged
merged 7 commits into from Apr 5, 2022

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Mar 10, 2022

Allow google-api-core<3.0.0dev on previous release of library. Note that this PR is to the protected branch v1, not main.

This will be followed by a release PR and is a step towards removing googleapis/google-cloud-python#10566

@busunkim96 busunkim96 requested a review from parthea March 10, 2022 23:37
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Mar 10, 2022
@parthea parthea changed the title chore(deps): allow google-api-core v2 on v1 release fix(deps): require google-api-core >= 1.31.5, >= 2.3.2 on v1 release Mar 14, 2022
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Apr 4, 2022
@busunkim96 busunkim96 merged commit dadf010 into v1 Apr 5, 2022
@busunkim96 busunkim96 deleted the v1-api-core-pin branch April 5, 2022 21:38
@release-please release-please bot mentioned this pull request Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/python-firestore API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants