Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expose Count, FieldFilter, Or, and And to firestore module #706

Merged
merged 2 commits into from Apr 26, 2023
Merged

fix: expose Count, FieldFilter, Or, and And to firestore module #706

merged 2 commits into from Apr 26, 2023

Conversation

Mariatta
Copy link
Contributor

Expose the Count, FieldFilter, Or, and And to the firestore module from the firestore_v1.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #704 馃

@Mariatta
fix: expose Count, FieldFilter, Or, and And to firestore module
93daf3d 
Expose the `Count`, `FieldFilter`, `Or`, and `And` to the `firestore` module from the `firestore_v1`.
@Mariatta Mariatta requested review from a team as code owners April 25, 2023 18:25
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: firestore Issues related to the googleapis/python-firestore API. labels Apr 25, 2023
@Mariatta Mariatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2023
@Mariatta Mariatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2023
@Mariatta Mariatta merged commit 8eb2c88 into main Apr 26, 2023
19 checks passed
@Mariatta Mariatta deleted the fix-issue-704 branch April 26, 2023 16:46
@release-please release-please bot mentioned this pull request Apr 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@telpirion telpirion telpirion approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/python-firestore API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fit & finish: COUNT and OR queries should be available in firestore module
3 participants
@Mariatta @telpirion @yoshi-kokoro