Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actionable error: some errors related to rpc calls are missing debug info #766

Closed
daniel-sanche opened this issue Sep 20, 2023 · 0 comments · Fixed by #767
Closed

actionable error: some errors related to rpc calls are missing debug info #766

daniel-sanche opened this issue Sep 20, 2023 · 0 comments · Fixed by #767
Labels
api: firestore Issues related to the googleapis/python-firestore API.

Comments

@daniel-sanche
Copy link
Contributor

Looking at the exceptions raised in python-firestore, I found a couple places where custom ValueErrors are raised after failed rpc calls, discarding all the useful server debugging information

These should all use exception chaining to make sure the original error is preserved
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Sep 20, 2023
@daniel-sanche daniel-sanche mentioned this issue Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/python-firestore API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ensure transactions rollback on failure googleapis/python-firestore
1 participant
@daniel-sanche