Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce compatibility with native namespace packages #792

Merged
merged 1 commit into from Nov 29, 2023
Merged

feat: Introduce compatibility with native namespace packages #792

merged 1 commit into from Nov 29, 2023
+40 −68

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Nov 14, 2023

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Nov 14, 2023
@parthea parthea added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed size: m Pull request size is medium. labels Nov 14, 2023
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Nov 14, 2023
@parthea
Copy link
Contributor Author

parthea commented Nov 14, 2023

Adding do not merge as there is an upcoming release freeze. This should be merged after the release freeze ends on November 29th.

@parthea parthea force-pushed the migrate-to-native-namespace-packages branch from b974f2c to 23a0f4b Compare November 21, 2023 22:01
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Nov 21, 2023
@parthea parthea marked this pull request as ready for review November 29, 2023 20:45
@parthea parthea requested review from a team as code owners November 29, 2023 20:45
@parthea parthea added owlbot:run Add this label to trigger the Owlbot post processor. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Nov 29, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 29, 2023
daniel-sanche
daniel-sanche approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-sanche daniel-sanche merged commit 510adce into main Nov 29, 2023
22 checks passed
@daniel-sanche daniel-sanche deleted the migrate-to-native-namespace-packages branch November 29, 2023 23:43
@release-please release-please bot mentioned this pull request Nov 29, 2023
Merged
@parthea parthea mentioned this pull request Nov 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-sanche daniel-sanche daniel-sanche approved these changes

Assignees

@daniel-sanche daniel-sanche

Labels
api: firestore Issues related to the googleapis/python-firestore API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@parthea @daniel-sanche