Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary detect_resource calls from CloudLoggingHandler #484

Merged
merged 12 commits into from
Feb 11, 2022

Conversation

daniel-sanche
Copy link
Contributor

Fixes #475

Previously, CLoudLoggingHandler would always call detect_resource, even when a resource is passed in. This was because the handler class wasn't sending the resource to the Transport class, so it would create a new logger that would have to re-detect the resource before usage (even though the resource field will be set by handlers in this case).

This PR fixes the issue by adding an optional resource argument to the transport classes, and making CloudLoggingHandler populate the field.

This PR also adds a timeout to detect_resource to prevent similar issues in the future.

@daniel-sanche daniel-sanche requested review from a team as code owners February 7, 2022 20:34
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: logging Issues related to the googleapis/python-logging API. labels Feb 7, 2022
@daniel-sanche daniel-sanche changed the title fix: cloudlogginghandler always calls detectresource fix: remove unnecessary detect_resource calls from CloudLoggingHandler Feb 7, 2022
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Feb 10, 2022
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 10, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 10, 2022
@daniel-sanche daniel-sanche merged commit def7440 into main Feb 11, 2022
@daniel-sanche daniel-sanche deleted the fix-detect-hang branch February 11, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/python-logging API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to bypass detect_resource/retrieve_metadata_server in 3.0.0
3 participants