Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cloud_run_job monitored resource type. #788

Merged
merged 2 commits into from Sep 29, 2023

Conversation

aaron-lerner
Copy link
Contributor

Environment variables are defined here: https://cloud.google.com/run/docs/container-contract#jobs-env-vars.

Fixes #663 馃

@aaron-lerner aaron-lerner requested review from a team as code owners September 27, 2023 23:13
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Sep 27, 2023
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Sep 27, 2023
@aaron-lerner aaron-lerner changed the title Add cloud_run_job monitored resource type. feat: Add cloud_run_job monitored resource type Sep 28, 2023
@conventional-commit-lint-gcf
Copy link

馃 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@aaron-lerner aaron-lerner changed the title feat: Add cloud_run_job monitored resource type feat: add cloud_run_job monitored resource type. Sep 28, 2023
@daniel-sanche daniel-sanche added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 28, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 28, 2023
Copy link
Contributor

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for putting this together

@daniel-sanche daniel-sanche added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 29, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 29, 2023
@daniel-sanche daniel-sanche merged commit 3b310d6 into googleapis:main Sep 29, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/python-logging API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloud Run Jobs log format not well implemented
3 participants