Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use warning instead of warn in system tests to avoid DeprecationWarning #821

Merged
merged 3 commits into from Dec 5, 2023
Merged

fix: Use warning instead of warn in system tests to avoid DeprecationWarning #821

merged 3 commits into from Dec 5, 2023

Conversation

gkevinzheng
Copy link
Contributor

Fixes #820 馃

@gkevinzheng gkevinzheng requested a review from a team as a code owner December 4, 2023 16:05
@gkevinzheng gkevinzheng requested a review from a team as a code owner December 4, 2023 16:05
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: logging Issues related to the googleapis/python-logging API. labels Dec 4, 2023
parthea
parthea approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please also remove the line in pytest.ini which ignores the warning

python-logging/pytest.ini

Lines 20 to 21 in 0ba8220

# Remove once https://github.com/googleapis/python-logging/issues/820 is fixed
ignore:.*warn.*is deprecated, use.*warning.*instead:DeprecationWarning

@gkevinzheng gkevinzheng merged commit c447175 into main Dec 5, 2023
17 checks passed
@gkevinzheng gkevinzheng deleted the use-warning branch December 5, 2023 18:39
@release-please release-please bot mentioned this pull request Dec 5, 2023
Merged
@parthea parthea mentioned this pull request Dec 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

Assignees

@parthea parthea

Labels
api: logging Issues related to the googleapis/python-logging API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeprecationWarning in Kokoro build log The 'warn' method is deprecated, use 'warning' instead
2 participants
@gkevinzheng @parthea