Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Mark database argument for get_by_id and its async counterpart as ignored #905

Merged
merged 3 commits into from Aug 9, 2023

Conversation

rwhogg
Copy link
Contributor

@rwhogg rwhogg commented Aug 4, 2023

The Client class should be used to set the database instead.

@rwhogg rwhogg requested review from a team as code owners August 4, 2023 16:00
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-ndb API. label Aug 4, 2023
…as ignored

The Client class should be used to set the database instead.
@rwhogg
Copy link
Contributor Author

rwhogg commented Aug 4, 2023

See #906

Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added optional suggestion to wording

google/cloud/ndb/model.py Outdated Show resolved Hide resolved
google/cloud/ndb/model.py Outdated Show resolved Hide resolved
rwhogg and others added 2 commits August 9, 2023 13:02
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@rwhogg rwhogg enabled auto-merge (squash) August 9, 2023 17:02
@rwhogg rwhogg changed the title Mark database argument for get_by_id and its async counterpart as ignored docs: Mark database argument for get_by_id and its async counterpart as ignored Aug 9, 2023
@rwhogg rwhogg added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 9, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 9, 2023
@rwhogg rwhogg merged commit b0f4310 into googleapis:main Aug 9, 2023
6 checks passed
@rwhogg rwhogg deleted the document-ignored branch August 9, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the googleapis/python-ndb API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants