Skip to content
This repository has been archived by the owner on Jul 6, 2023. It is now read-only.

fix!: remove policy based routing API #228

Merged
merged 7 commits into from
Feb 9, 2023
Merged

fix!: remove policy based routing API #228

merged 7 commits into from
Feb 9, 2023

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Jan 27, 2023 •
edited
Loading

  • Regenerate this pull request now.

PiperOrigin-RevId: 507808936

Source-Link: googleapis/googleapis@64cf849

Source-Link: https://github.com/googleapis/googleapis-gen/commit/53c48cac153d3b37f3d2c2dec4830cfd91ec4153
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9

BEGIN_NESTED_COMMIT
fix!: remove policy based routing API
PiperOrigin-RevId: 505139690

Source-Link: googleapis/googleapis@183d61a

Source-Link: https://github.com/googleapis/googleapis-gen/commit/58af86ac496b5d1a0c0f5ba4019149f9d66b5663
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNThhZjg2YWM0OTZiNWQxYTBjMGY1YmE0MDE5MTQ5ZjlkNjZiNTY2MyJ9
END_NESTED_COMMIT

@gcf-owl-bot
fix!: remove policy based routing API
4ee31c5 
PiperOrigin-RevId: 505139690

Source-Link: googleapis/googleapis@183d61a

Source-Link: googleapis/googleapis-gen@58af86a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNThhZjg2YWM0OTZiNWQxYTBjMGY1YmE0MDE5MTQ5ZjlkNjZiNTY2MyJ9
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner January 27, 2023 19:49
@snippet-bot
Copy link

snippet-bot bot commented Jan 27, 2023 •
edited
Loading

Here is the summary of changes.

You are about to delete 8 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 27, 2023
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Jan 27, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 27, 2023
@product-auto-label product-auto-label bot added the api: networkconnectivity Issues related to the googleapis/python-network-connectivity API. label Jan 27, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner January 27, 2023 19:51
@gcf-owl-bot gcf-owl-bot bot requested a review from dandhlee January 27, 2023 19:51
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 27, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 27, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 28, 2023
@parthea parthea added next major: breaking change this is a change that we should wait to bundle into the next major version and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 28, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 28, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 28, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 28, 2023
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 28, 2023
@parthea
Copy link
Contributor

parthea commented Jan 28, 2023 •
edited
Loading

The breaking change was approved in b/265357323 as the feature was not made available for public use in the backend. The changes look good. We will bump the major version as this is technically a breaking change regardless if this was unused. I will hold off on merging this PR for 2 weeks to allow time for changes to settle in case there is another breaking change coming.

@gcf-owl-bot
chore: Update gapic-generator-python to v1.8.4
d05eb56 
PiperOrigin-RevId: 507808936

Source-Link: googleapis/googleapis@64cf849

Source-Link: googleapis/googleapis-gen@53c48ca
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9
@gcf-owl-bot gcf-owl-bot bot changed the title fix!: remove policy based routing API chore: Update gapic-generator-python to v1.8.4 Feb 7, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 7, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 7, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 7, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 7, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2023
@parthea parthea changed the title chore: Update gapic-generator-python to v1.8.4 fix!: remove policy based routing API Feb 8, 2023
@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 9, 2023
@parthea parthea merged commit 03f9adb into main Feb 9, 2023
@parthea parthea deleted the owl-bot-copy branch February 9, 2023 19:20
@release-please release-please bot mentioned this pull request Feb 9, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@parthea parthea parthea approved these changes

@dandhlee dandhlee Awaiting requested review from dandhlee dandhlee was automatically assigned from googleapis/python-samples-reviewers

Assignees
No one assigned
Labels
api: networkconnectivity Issues related to the googleapis/python-network-connectivity API. next major: breaking change this is a change that we should wait to bundle into the next major version owl-bot-copy size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@parthea @yoshi-kokoro