Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove LOGGER.exception() line #1087

Merged
merged 2 commits into from Feb 23, 2024
Merged

fix: Remove LOGGER.exception() line #1087

merged 2 commits into from Feb 23, 2024

Conversation

mukund-ananthu
Copy link
Contributor

@mukund-ananthu mukund-ananthu commented Feb 22, 2024

Information logged in this line will be available to the calling code via the exception thrown.

There are scenarios where due to concurrency issues, there are two uncoordinated outputs happening at once. This may result in this line logging stack traces after log statements in the exception block of the calling code.

Fixes #1086 馃

@mukund-ananthu mukund-ananthu requested review from a team as code owners February 22, 2024 20:57
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/python-pubsub API. labels Feb 22, 2024
@mukund-ananthu mukund-ananthu changed the title Remove LOGGER.exception() line fix: Remove LOGGER.exception() line Feb 22, 2024
Copy link

conventional-commit-lint-gcf bot commented Feb 22, 2024

馃 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Information logged in this line will be available to the calling code
  via the exception thrown.

There are scenarios where due to concurrency issues,  there are two uncoordinated outputs happening at once. This may result in this line logging stack traces after log statements in the exception block of the calling code.
@mukund-ananthu mukund-ananthu enabled auto-merge (squash) February 23, 2024 00:12
@mukund-ananthu mukund-ananthu self-assigned this Feb 23, 2024
@mukund-ananthu mukund-ananthu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 23, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 23, 2024
@mukund-ananthu mukund-ananthu merged commit a395d26 into main Feb 23, 2024
26 of 28 checks passed
@mukund-ananthu mukund-ananthu deleted the removeLog branch February 23, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack trace logged after calling code has already handled the exception.
3 participants