Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional argument for max delivery attempts when creating or updating subscription with dead lettering #235

Closed
danavaziri-ga opened this issue Nov 11, 2020 · 0 comments · Fixed by #236
Assignees
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. type: docs Improvement to the documentation for an API.

Comments

@danavaziri-ga
Copy link
Contributor

To make the sample python code resemble the UI and CPS behavior a bit more we could add an optional max_delivery_attempts argument instead of setting the value to 10(when we create subscription) or 20(when we update subscription). If the user decides not to set the max_delivery_attempts argument we can set it to the default of 5 just like CPS does.

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Nov 11, 2020
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Nov 12, 2020
@meredithslota meredithslota added samples Issues that are directly related to samples. type: docs Improvement to the documentation for an API. and removed triage me I really want to be triaged. labels Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. type: docs Improvement to the documentation for an API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants