Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate 'return_immediately' argument #350

Closed
tseaver opened this issue Mar 25, 2021 · 2 comments · Fixed by #355
Closed

Deprecate 'return_immediately' argument #350

tseaver opened this issue Mar 25, 2021 · 2 comments · Fixed by #355
Assignees
@plamut
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: cleanup An internal cleanup or hygiene concern. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tseaver
Copy link
Contributor

tseaver commented Mar 25, 2021

Backend says it is deprectated: we should ensure we issue a DeprecationWarning if the user passes it as True.

Per today's status call.

/cc @hongalex, @kamalaboulhosn
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Mar 25, 2021
@meredithslota meredithslota added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. type: cleanup An internal cleanup or hygiene concern. labels Mar 25, 2021
@meredithslota
Copy link
Contributor

Tagged this as both feature request and clean-up, feel free to triage otherwise. :)

@quartzmo quartzmo mentioned this issue Mar 25, 2021
Closed
@plamut plamut mentioned this issue Mar 29, 2021
Open
@plamut
Copy link
Contributor

plamut commented Mar 29, 2021 •
edited
Loading

Will be fixed in the generator itself (PR).

Edit: If the proposed change gets accepted, that is, there are some reservations about it.

Update: After the discussion we decided to do this change through synth.py.

This was referenced Mar 30, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plamut plamut

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: cleanup An internal cleanup or hygiene concern. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: emit a warning if return_immediately flag is set with synchronous pull plamut/python-pubsub
3 participants
@tseaver @plamut @meredithslota