Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Docs have inconsistent default values for max_latency and max_bytes #572

Merged
merged 4 commits into from
Jan 25, 2022

Conversation

acocuzzo
Copy link
Contributor

There is inconsistency in the documentation about the default value of max_latency, changing this to .01 s (which also reflects the correct unit).

Adding detail on the default values of BatchSettings in batching documentation, as well as fixing the comment in the publisher sample of the max_bytes default value.

Fixes #507 🦕

@acocuzzo acocuzzo requested review from a team as code owners January 24, 2022 23:12
@acocuzzo acocuzzo requested a review from parthea January 24, 2022 23:12
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Jan 24, 2022
@anguillanneuf anguillanneuf changed the title Fix: Docs have inconsistent default values for max_latency and max_bytes docs: Docs have inconsistent default values for max_latency and max_bytes Jan 24, 2022
@anguillanneuf
Copy link
Contributor

@acocuzzo If you amend your commit message and prefix it with docs:, the conventional commits check should pass.

@anguillanneuf anguillanneuf self-requested a review January 25, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency in documentation on max_latency
2 participants