Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove expired ack_ids #787

Merged
merged 7 commits into from
Sep 22, 2022

Conversation

acocuzzo
Copy link
Contributor

@acocuzzo acocuzzo commented Sep 21, 2022

When eod is enabled:
(1) Return a list of expired_ack_ids from send_lease_modacks, otherwise return an empty list
(2) In _on_response, check that a message's ack_id is not in expired_ack_ids before adding to leaser and putting the message on hold
Fixes #786 馃 and possibly #593

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the googleapis/python-pubsub API. labels Sep 21, 2022
@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 21, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 21, 2022
@acocuzzo acocuzzo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 21, 2022
@acocuzzo acocuzzo marked this pull request as ready for review September 21, 2022 20:44
@acocuzzo acocuzzo requested review from a team as code owners September 21, 2022 20:44
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 21, 2022
Copy link
Contributor

@pradn pradn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not certain this will help with the linked issue, but we should make the change in any case.

@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 22, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 22, 2022
@acocuzzo acocuzzo merged commit b4b809d into googleapis:main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove expired ack_ids from lease management.
4 participants