Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure that _failure_task exception is always retrieved #301

Merged
merged 1 commit into from
Feb 17, 2022
Merged

fix: ensure that _failure_task exception is always retrieved #301

merged 1 commit into from
Feb 17, 2022

Conversation

dpcollins-google
Copy link
Collaborator

Fixes #285

@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/python-pubsublite API. label Feb 17, 2022
anguillanneuf
anguillanneuf approved these changes Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding this fix.

@dpcollins-google dpcollins-google merged commit 579abf3 into main Feb 17, 2022
@dpcollins-google dpcollins-google deleted the fix-future-warning branch February 17, 2022 19:32
@release-please release-please bot mentioned this pull request Feb 17, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 18, 2022
@release-please
chore(main): release 1.4.0 (#292)
95ce265 
🤖 I have created a release *beep* *boop*
---


## [1.4.0](v1.3.0...v1.4.0) (2022-02-18)


### Features

* add api key support ([#291](#291)) ([f0d65ca](f0d65ca))


### Bug Fixes

* ensure bytes cannot go negative on requests sent to the server ([#300](#300)) ([6d3690a](6d3690a)), closes [#294](#294)
* ensure that _failure_task exception is always retrieved ([#301](#301)) ([579abf3](579abf3))
* resolve DuplicateCredentialArgs error when using credentials_file ([b7ed9ad](b7ed9ad))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguillanneuf anguillanneuf anguillanneuf approved these changes

Assignees
No one assigned
Labels
api: pubsublite Issues related to the googleapis/python-pubsublite API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected logging in Python ≥ 3.8 by Lite publisher client
2 participants
@dpcollins-google @anguillanneuf