You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't agree with this, the wrapper objects cleanly isolate parsing vs client errors, and have a "parse" method to get this from the underlying string. I'm going to change the admin layer to just accept the wrappers for consistency, is this an acceptable end-state? It would mean you'd call:
response = client.get_topic(TopicPath(project_number, location, topic_id))
or
response = client.get_topic(TopicPath.parse("projects/xxx/locations/xxx/topics/xxx"))
Currently the admin client expects strings
python-pubsublite/samples/snippets/get_lite_topic_example.py
Lines 40 to 42 in 9ca10e5
while the publisher and subscriber clients expect typed object.
python-pubsublite/samples/snippets/publisher_example.py
Lines 40 to 42 in 9ca10e5
Ideally we shall accept both formats.
The text was updated successfully, but these errors were encountered: