Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

Sample test test_search_with_query_expansion_spec failing #375

Closed
parthea opened this issue Dec 16, 2022 · 1 comment · Fixed by #381
Closed

Sample test test_search_with_query_expansion_spec failing #375

parthea opened this issue Dec 16, 2022 · 1 comment · Fixed by #381
Assignees
Labels
api: retail Issues related to the googleapis/python-retail API. external This issue is blocked on a bug with the actual product. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@parthea
Copy link
Contributor

parthea commented Dec 16, 2022

Sample test test_search_with_query_expansion_spec started failing today. See build log here:

Previously using a search request of "Google Youth Hero Tee Grey" would return "Google Youth Hero Tee Grey" as the first product. This is no longer the case. The test passes if I change the search request to "Google+Youth+Hero+Tee+Grey"

search_request = get_search_request("Google Youth Hero Tee Grey", condition)

=================================== FAILURES ===================================
____________________ test_search_with_query_expansion_spec _____________________
[gw2] linux -- Python 3.7.12 /workspace/samples/interactive-tutorials/search/.nox/py-3-7/bin/python

    def test_search_with_query_expansion_spec():
        response = search()

>       assert response.results[0].product.title == "Google Youth Hero Tee Grey"
E       AssertionError: assert 'Google Toddl...harcoal Black' == 'Google Youth Hero Tee Grey'
E         - Google Youth Hero Tee Grey
E         + Google Toddler Hero Tee Charcoal Black

search_with_query_expansion_spec_test.py:39: AssertionError
@product-auto-label product-auto-label bot added the api: retail Issues related to the googleapis/python-retail API. label Dec 16, 2022
@parthea parthea added samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. external This issue is blocked on a bug with the actual product. labels Dec 16, 2022
@parthea
Copy link
Contributor Author

parthea commented Jan 5, 2023

Closing as obsolete

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: retail Issues related to the googleapis/python-retail API. external This issue is blocked on a bug with the actual product. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants