Add nox target for django tests #474
Labels
api: spanner
Issues related to the googleapis/python-spanner-django API.
priority: p1
Important issue which blocks shipping the next release. Will be fixed prior to next release.
type: process
A process-related concern. May include testing, release, or the like.
Right now we run django's built in tests in CI using
python runtests.py
, but it looks like pip-installing django doesn't give us an executableruntests.py
without us changingPYTHONPATH
.Kokoro seems to get around this by installing django from source, from @timgraham's fork:
python-spanner-django/.kokoro/build.sh
Line 60 in bfde221
Running the existing tox target (from 11222db) doesn't appear to work:
Since @mf2199 replaced tox with nox in #468, we need a nox target to run the built-in django tests. This target shouldn't depend on kokoro scripts (like
django_test_suite.sh
does now), and the existing scripts should be changed to remove dependencies on the fork if possible.See also #471.
The text was updated successfully, but these errors were encountered: