feat: return list of dictionaries for execute streaming sql #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
| @@ -190,6 +190,19 @@ def one_or_none(self): | |||
| except StopIteration: | |||
| return answer | |||
|
|
|||
| def fetch_as_dictionary_list(self): | |||
| rows = [] | |||
| for row in self: | |||
There was a problem hiding this comment.
What happens if rows are not fully processed when this method is called ?
There was a problem hiding this comment.
There will be a delay in returning the result in those cases but always the full result will be returned
rajatbhatta
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.