Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implementation for partitioned query in dbapi #1067

Merged
merged 7 commits into from
Jan 10, 2024
Merged

feat: Implementation for partitioned query in dbapi #1067

merged 7 commits into from
Jan 10, 2024

Conversation

ankiaga
Copy link
Contributor

@ankiaga ankiaga commented Jan 2, 2024

No description provided.

@ankiaga ankiaga requested review from a team as code owners January 2, 2024 13:01
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/python-spanner API. labels Jan 2, 2024
@ankiaga ankiaga requested a review from olavloite January 2, 2024 13:02
olavloite
olavloite reviewed Jan 2, 2024
View reviewed changes
Copy link
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks generally good to me. I think we need some more tests that cover the un-happy path (e.g. what happens if you try to use this in a read/write transaction?)

google/cloud/spanner_dbapi/parsed_statement.py Outdated Show resolved Hide resolved
google/cloud/spanner_dbapi/partition_helper.py Show resolved Hide resolved
google/cloud/spanner_dbapi/partition_helper.py Outdated Show resolved Hide resolved
@ankiaga ankiaga requested a review from aseering January 3, 2024 07:21
olavloite
olavloite approved these changes Jan 9, 2024
View reviewed changes
google/cloud/spanner_dbapi/client_side_statement_executor.py Show resolved Hide resolved
google/cloud/spanner_dbapi/client_side_statement_executor.py Show resolved Hide resolved
google/cloud/spanner_dbapi/client_side_statement_executor.py Show resolved Hide resolved
tests/system/test_dbapi.py Outdated Show resolved Hide resolved
tests/system/test_dbapi.py Outdated Show resolved Hide resolved
tests/system/test_dbapi.py Outdated Show resolved Hide resolved
tests/system/test_dbapi.py Outdated Show resolved Hide resolved
@ankiaga ankiaga merged commit 63daa8a into googleapis:main Jan 10, 2024
12 of 13 checks passed
@release-please release-please bot mentioned this pull request Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

@aseering aseering Awaiting requested review from aseering

@manu2 manu2 Awaiting requested review from manu2

@pratickchokhani pratickchokhani Awaiting requested review from pratickchokhani

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ankiaga @olavloite