Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Unskip test_create_client_with_query_options #769

Merged
merged 2 commits into from
Jul 11, 2022
Merged

fix: Unskip test_create_client_with_query_options #769

merged 2 commits into from
Jul 11, 2022

Conversation

asthamohta
Copy link
Contributor

No description provided.

@asthamohta asthamohta requested review from a team as code owners July 8, 2022 23:18
@asthamohta asthamohta requested a review from dandhlee July 8, 2022 23:18
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/python-spanner API. labels Jul 8, 2022
@asthamohta asthamohta linked an issue Jul 8, 2022 that may be closed by this pull request
Unskip test_create_client_with_query_options #421
Closed
@asthamohta asthamohta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 8, 2022
ansh0l
ansh0l approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@ansh0l ansh0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asthamohta asthamohta merged commit 58640a1 into googleapis:main Jul 11, 2022
@release-please release-please bot mentioned this pull request Jul 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansh0l ansh0l ansh0l approved these changes

@dandhlee dandhlee Awaiting requested review from dandhlee dandhlee is a code owner automatically assigned from googleapis/python-samples-reviewers

@IlyaFaer IlyaFaer Awaiting requested review from IlyaFaer

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unskip test_create_client_with_query_options
4 participants
@asthamohta @ansh0l @yoshi-kokoro @parthea