Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fgac support and samples #867

Merged
merged 8 commits into from
Dec 13, 2022
Merged

feat: fgac support and samples #867

merged 8 commits into from
Dec 13, 2022

Conversation

asthamohta
Copy link
Contributor

@asthamohta asthamohta commented Dec 13, 2022 •
edited
Loading

enable_fine_grained_access sample requires service account to work, so skipping integration tests for the same.

@asthamohta asthamohta requested review from a team as code owners December 13, 2022 05:21
@snippet-bot
Copy link

snippet-bot bot commented Dec 13, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. labels Dec 13, 2022
rajatbhatta
rajatbhatta approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a few minor comments.

google/cloud/spanner_v1/database.py Outdated Show resolved Hide resolved
google/cloud/spanner_v1/pool.py Show resolved Hide resolved
samples/samples/snippets.py Show resolved Hide resolved
samples/samples/snippets_test.py Show resolved Hide resolved
@asthamohta asthamohta added the automerge Merge the pull request once unit tests and other checks pass. label Dec 13, 2022
@asthamohta asthamohta enabled auto-merge (squash) December 13, 2022 11:49
@asthamohta asthamohta merged commit 24fa244 into googleapis:main Dec 13, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 13, 2022
@release-please release-please bot mentioned this pull request Dec 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajatbhatta rajatbhatta rajatbhatta approved these changes

@leahecole leahecole Awaiting requested review from leahecole leahecole is a code owner automatically assigned from googleapis/python-samples-reviewers

@IlyaFaer IlyaFaer Awaiting requested review from IlyaFaer

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asthamohta @rajatbhatta