feat: add gccl-gcs-cmd field to X-Goog-API-Client header for Transfer Manager calls #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xl
* Refactor client.download_blob_to_file * Chore: clean up code * refactor blob and client unit tests * lint reformat * Rename _prep_and_do_download
* Refactor client.download_blob_to_file * Chore: clean up code * refactor blob and client unit tests * lint reformat * Rename _prep_and_do_download * Refactor blob.upload_from_file * Lint reformat
…1082) * Refactor client.download_blob_to_file * Chore: clean up code * refactor blob and client unit tests * lint reformat * Rename _prep_and_do_download * Refactor blob.upload_from_file * Lint reformat * feature: add 'command' argument to private upload/download interface * lint reformat * reduce duplication and edit docstring
…sfer manager (#1096) * Refactor client.download_blob_to_file * Chore: clean up code * refactor blob and client unit tests * lint reformat * Rename _prep_and_do_download * Refactor blob.upload_from_file * Lint reformat * feature: add 'command' argument to private upload/download interface * lint reformat * reduce duplication and edit docstring * feature: utilize new private interface to pass 'command' through transfer manager * add default value to content_type in blob.handle_filename_and_upload() * add 'command' to downloan_chunks_concurrently * docstring editing * refactor transfer manager unit tests * refactor expected download/upload kwargs
andrewsg
force-pushed
the
tm-metrics
branch
from
e8614c1
to
fa848b7
Compare
cojenco
approved these changes
Sep 18, 2023
google/cloud/storage/_helpers.py
Outdated
| :param user_agent: The user-agent for requests. | ||
|
|
||
| :type command: str | ||
| :param command: |
There was a problem hiding this comment.
nit: indentation?
another nit: any particular reason why this PR is tagged as a fix?
There was a problem hiding this comment.
I wasn't sure how to tag it. It's not customer-facing so it's not a feat. But it seems bigger than a chore.
Fix is for point releases, feat is for minor releases. I think this is more of a point release thing, so fix. I could be convinced otherwise.
| @@ -769,7 +769,7 @@ def test_upload_chunks_concurrently_with_metadata_and_encryption(): | |||
| "Accept": "application/json", | |||
| "Accept-Encoding": "gzip, deflate", | |||
| "User-Agent": "agent", | |||
| "X-Goog-API-Client": "agent gccl-invocation-id/{}".format(invocation_id), | |||
| "X-Goog-API-Client": f"agent gccl-invocation-id/{invocation_id} gccl-gcs-cmd/tm.upload_sharded", | |||
andrewsg
changed the title
andrewsg
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.