Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bucket.delete(force=True) now works with version-enabled buckets #1172

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

andrewsg
Copy link
Contributor

@andrewsg andrewsg commented Oct 27, 2023

Fixes #1071 🦕

As a side-effect, the behavior of this method during a race condition has changed slightly. Previously, if a new object was created while the bucket.delete(force=True) method is running, it would fail, but if a new generation of an existing object was uploaded, it would still succeed. Now it will fail in both cases. Regardless of the exact behavior, please do not use this method on a bucket that is still being updated by another process.

@andrewsg andrewsg requested review from a team as code owners October 27, 2023 19:14
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. labels Oct 27, 2023
@andrewsg andrewsg added the automerge Merge the pull request once unit tests and other checks pass. label Oct 31, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 0de09d3 into main Oct 31, 2023
13 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the force branch October 31, 2023 17:10
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bucket.delete(force=True) does not work if versioning is enabled
3 participants