Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support HNS enablement in bucket metadata #1278

Merged
merged 2 commits into from
May 22, 2024
Merged

feat: support HNS enablement in bucket metadata #1278

merged 2 commits into from
May 22, 2024

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented May 21, 2024

Fixes #1269

@cojenco cojenco requested review from a team as code owners May 21, 2024 17:22
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. labels May 21, 2024
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label May 21, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 21, 2024
frankyn
frankyn reviewed May 21, 2024
View reviewed changes
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More of comment feedback otherwise LGTM.

google/cloud/storage/bucket.py Show resolved Hide resolved
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 22, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 22, 2024
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2024
@cojenco cojenco merged commit add3c01 into googleapis:main May 22, 2024
15 checks passed
@release-please release-please bot mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankyn frankyn frankyn approved these changes

Assignees

@tritone tritone

Labels
api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FR: Support HNS enablement in bucket metadata
4 participants
@cojenco @frankyn @tritone @yoshi-kokoro