Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage: access token field is unused in system test 'test_create_signed_read_url_*_w_access_token' #46

Closed
HemangChothani opened this issue Feb 6, 2020 · 0 comments · Fixed by #47
Closed

Storage: access token field is unused in system test 'test_create_signed_read_url_*_w_access_token' #46

HemangChothani opened this issue Feb 6, 2020 · 0 comments · Fixed by #47
Assignees
@HemangChothani
Labels
api: storage Issues related to the googleapis/python-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@HemangChothani
Copy link
Contributor

Currently in the system test blob.generate_signed_url method passing access_token=None, Due to that test_create_signed_read_url_*_w_access_token test not executed properly,so needs to pass value of access_token. also need to change the scope which passing to generate the access token as the current one is not working.
@HemangChothani HemangChothani added api: storage Issues related to the googleapis/python-storage API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 6, 2020
@HemangChothani HemangChothani self-assigned this Feb 6, 2020
@HemangChothani HemangChothani mentioned this issue Feb 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HemangChothani HemangChothani

Labels
api: storage Issues related to the googleapis/python-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(storage): fix system test and change scope for iam access token HemangChothani/python-storage
1 participant
@HemangChothani