Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add setuptools to dependencies #740

Closed
cbini opened this issue Mar 23, 2022 · 1 comment · Fixed by #744
Closed

add setuptools to dependencies #740

cbini opened this issue Mar 23, 2022 · 1 comment · Fixed by #744
Assignees
Labels
api: storage Issues related to the googleapis/python-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@cbini
Copy link

cbini commented Mar 23, 2022

If you import this library in an isolated environment, it will fail with ModuleNotFoundError: No module named 'pkg_resources' due to the line referenced below. While setuptools is a commonly installed alongside Python, it's not a core module, and should be listed as a dependency so that package managers (e.g. pipenv, poetry, pdm) will pick up on it and install it.

import pkg_resources

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Mar 23, 2022
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Mar 23, 2022
@danielbankhead danielbankhead added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Mar 23, 2022
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Mar 23, 2022
@andrewsg
Copy link
Contributor

You're right! Our automated testing uses setuptools to install the dependencies so it's always installed, but that's not necessarily true of other environments. Thank you for letting us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
4 participants