-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for use_auth_w_custom_endpoint #901
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had one question, otherwise LGTM. Thanks!
Update: pending discussion with the GCS EngProd team to streamline usage and validate testing against non-prod environments |
Synced offline with @rsaksham - prepod testing should not be affected by this change. PR is ready to merge and release once freeze ends |
)" This reverts commit 4862a9c.
This adds a boolean flag
use_auth_w_custom_endpoint
- whether authentication is required with custom endpointsFor backwards compatibility
STORAGE_EMULATOR_HOST
is setFixes #895 and internal b/258502260