Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manifest release not updating any package.json versions #1317

Closed
dyladan opened this issue Feb 28, 2022 · 4 comments · Fixed by #1319
Closed

Manifest release not updating any package.json versions #1317

dyladan opened this issue Feb 28, 2022 · 4 comments · Fixed by #1319
Assignees
@chingor13
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@dyladan
Copy link

dyladan commented Feb 28, 2022

Our manifest releaser is not updating the version field of any package.json files. It recognizes that the versions have changed and correctly creates changelog files and updates the dependencies field to reflect what the new version should be, but the actual version field itself is incorrect

You can see an example of this here https://github.com/open-telemetry/opentelemetry-js-contrib/pull/924/files

Environment details

  • OS: macos and linux
  • Node.js version: 16
  • npm version: 7
  • release-please version: 13.4.12
@dyladan dyladan added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 28, 2022
@dyladan dyladan mentioned this issue Feb 28, 2022
Merged
@chingor13 chingor13 self-assigned this Feb 28, 2022
@chingor13
Copy link
Contributor

This looks like a bug for sure. We're updating the dependency versions, but not the main version in the package.json

@dyladan
Copy link
Author

dyladan commented Feb 28, 2022

Is there anything I can do in the meantime to unblock my release? we just switched from the github action v2 to v3 and that changed the branch name which required a pull request with reviews and for me to go through the admin approval process to change our branch protection rule name. Not really something I'm excited to do again to roll back.

@chingor13 chingor13 mentioned this issue Feb 28, 2022
Merged
@chingor13
Copy link
Contributor

I ran the CLI from the branch in #1319 and it created open-telemetry/opentelemetry-js-contrib#926

It looks like there's a weird oddity with empty "Dependencies" sections in the changelogs, but the version numbers now look correct

@chingor13
Copy link
Contributor

This fix was rolled out to the action in https://github.com/google-github-actions/release-please-action/releases/tag/v3.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: node-workspace plugin should update package.json versions googleapis/release-please
2 participants
@chingor13 @dyladan