Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow plugins to skip merging in-scope pull requests #1550

Merged
merged 5 commits into from
Aug 8, 2022

Conversation

chingor13
Copy link
Contributor

@chingor13 chingor13 commented Aug 4, 2022

By default, plugins that act across multiple candidate releases merge them together because they should be released together. This feature allows configuring the plugins so that they can skip this merge. This allows further plugins to see each modified candidate release.

Fixes #1457

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Aug 4, 2022
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Aug 4, 2022
@chingor13 chingor13 changed the title test: add failing test for combining workspace and linked-versions pl… feat: allow plugins to skip merging in-scope pull requests Aug 4, 2022
@chingor13 chingor13 marked this pull request as ready for review August 4, 2022 20:31
@chingor13 chingor13 requested a review from a team as a code owner August 4, 2022 20:31
@chingor13 chingor13 requested review from a team and bcoe August 4, 2022 20:31
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this solution, we should document the approach in manifest-releaser.md and in README.md if there's a place that makes sense.

@chingor13 chingor13 requested a review from bcoe August 8, 2022 18:37
@chingor13 chingor13 merged commit 354b1dc into main Aug 8, 2022
@chingor13 chingor13 deleted the linked-workspace branch August 8, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linked-versions and node-workspace plugins are incompatible
2 participants