Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins): introduce processCommits hook for plugins #1607

Merged
merged 4 commits into from
Aug 31, 2022
Merged

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Aug 26, 2022

Introduces processCommits hook for WorkspacePlugins, and implements the
SentenceCase plugin, which can be used to uppercase the first word
in a commit messages' description.

CC: @martinvarelaj

Introduces processCommits hook for WorkspacePlugins, and implements the
SentenceCase plugin, which can be used to uppercase the first word
in a commit messages' description
@bcoe bcoe requested a review from a team as a code owner August 26, 2022 22:24
@bcoe bcoe requested a review from a team August 26, 2022 22:24
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Aug 26, 2022
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to googleapis/repo-automation-bots#4125 (review), can we make the list of special words configurable?

docs/manifest-releaser.md Show resolved Hide resolved
src/plugins/sentence-case.ts Outdated Show resolved Hide resolved
src/plugin.ts Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Aug 31, 2022
@bcoe
Copy link
Contributor Author

bcoe commented Aug 31, 2022

can we make the list of special words configurable?

@chingor13 done ☝️

@bcoe bcoe requested a review from chingor13 August 31, 2022 19:12
@chingor13 chingor13 merged commit 414eb5f into main Aug 31, 2022
@chingor13 chingor13 deleted the sentence-case branch August 31, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants