Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle pull request files returned as null #1651

Merged
merged 3 commits into from
Sep 22, 2022
Merged

fix: handle pull request files returned as null #1651

merged 3 commits into from
Sep 22, 2022

Conversation

chingor13
Copy link
Contributor

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Sep 22, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Sep 22, 2022
@chingor13 chingor13 changed the title test: add failing test for graphQL not returning file nodes fix: handle pull request files returned as null Sep 22, 2022
@chingor13 chingor13 marked this pull request as ready for review September 22, 2022 21:51
@chingor13 chingor13 requested a review from a team as a code owner September 22, 2022 21:51
@chingor13 chingor13 requested a review from a team September 22, 2022 21:51
bcoe
bcoe approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any idea why this list is returned as null, are there actually no files associated?

@chingor13 chingor13 merged commit 4cea3dd into main Sep 22, 2022
@chingor13 chingor13 deleted the missing-pr-files branch September 22, 2022 22:10
@release-please release-please bot mentioned this pull request Sep 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chingor13 @bcoe