fix: manifest config bootstrapper should include schema field #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chingor13
changed the title
sofisl
approved these changes
Sep 30, 2022
| updates, | ||
| {} | ||
| ); | ||
| number: -1, |
There was a problem hiding this comment.
This field is marked as required but is actually only populated if it's an existing PR. We can't really remove it without a breaking interface change. It's on the list to clean up in the next SemVer major release.
soulfresh
added a commit
to soulfresh/release-please
that referenced
this pull request
Oct 11, 2022
* commit 'bc995058083b961b314547171495d58e6d5d6f8e': (26 commits) chore(main): release 14.11.2 (googleapis#1693) fix: add initial-version to allowed properties in manifest schema (googleapis#1691) chore(main): release 14.11.1 (googleapis#1688) fix: explicitly sort PRs by updated desc (googleapis#1685) chore(main): release 14.11.0 (googleapis#1683) feat(maven-workspace): update all discovered pom.xml within the components (googleapis#1667) chore(main): release 14.10.2 (googleapis#1682) fix(maven-workspace): preserve original pom.xml updater when bumping dependencies (googleapis#1680) chore(deps): update dependency sinon to v14.0.1 (googleapis#1681) chore(main): release 14.10.1 (googleapis#1679) fix: put config schema on correct file (googleapis#1678) docs: fix grammar and base strategy design href (googleapis#1674) chore(main): release 14.10.0 (googleapis#1673) feat(cli): add debug command for loading a manifest config (googleapis#1671) fix: manifest config bootstrapper should include schema field (googleapis#1670) feat: add ability to set extra labels on components (googleapis#1669) chore(main): release 14.9.0 (googleapis#1668) feat: add initial version to base strategy (googleapis#1665) chore(main): release 14.8.0 (googleapis#1663) feat: add `group-priority` plugin (googleapis#1660) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
$schemafield to the bootstrapped manifest config file. This helps IDEs automatically lint the config schema as it's being edited.Fixes the
--dry-runargument for the bootstrap command to output what it would propose as a changeFixes #1625
Fixes #1617
fix(cli): bootstrap command respects --dry-run argument