Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions of linked packages in package-lock.json to match package.json #1842

Closed
padaszewski opened this issue Feb 6, 2023 · 0 comments · Fixed by #2162
Closed

Update versions of linked packages in package-lock.json to match package.json #1842

padaszewski opened this issue Feb 6, 2023 · 0 comments · Fixed by #2162
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@padaszewski
Copy link

Related to #464

Is your feature request related to a problem? Please describe.
Let's consider following scenario:
modules
If there is an update for one of the modules A,B,C then the corresponding package-lock.json will be updated. However, if I update the CoreModule, then the other modules will also be updated (node-modules plugin), but the version of the CoreModule will not be updated in the package-lock.json of the other modules. After releasing it is necessary to run npm install (which causes a change in the module dir and may cause unwanted version updates in the future).
Describe the solution you'd like
The version of a submodule is updated in the package-lock.json file of the module that depends on it (which also gets a patch update because of the node-modules plugin).
Describe alternatives you've considered
No alternative considered.

@padaszewski padaszewski added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants