Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github-changelog-notes): prepend header to create parseable release notes #1912

Merged
merged 3 commits into from
Apr 11, 2023

Conversation

chingor13
Copy link
Contributor

@chingor13 chingor13 commented Apr 10, 2023

Adds a test to ensure the generated GitHubChangelogNotes can be parsed.

Fixes https://github.com/google-github-actions/release-please-action/issues/744

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Apr 10, 2023
@chingor13 chingor13 changed the title test: failing test for parsing generated github changelog notes fix(github-changelog-notes): prepend header to create parseable release notes Apr 10, 2023
@chingor13 chingor13 marked this pull request as ready for review April 10, 2023 22:35
@chingor13 chingor13 requested review from a team as code owners April 10, 2023 22:35
@chingor13 chingor13 enabled auto-merge (squash) April 10, 2023 23:28
@chingor13 chingor13 merged commit 3f53d40 into main Apr 11, 2023
11 checks passed
@chingor13 chingor13 deleted the fix-gh-changelog-notes branch April 11, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"changelog-notes-type: github" doesn't work properly
2 participants