Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not find release version with umbrella package and multiple packages without github release #1934

Closed
alex-enchi opened this issue Apr 27, 2023 · 0 comments · Fixed by #1935
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@alex-enchi
Copy link
Contributor

Thanks for stopping by to let us know something could be better!

Steps to reproduce

config.json

{
  "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json",
  "packages": {
    ".": {
      "changelog-path": "CHANGELOG.md",
      "component": "@company/umbrella"
    },
    "packages/foo": {
      "component": "@company/foo",
      "skip-github-release": true
    },
   "packages/foo": {
      "component": "@company/bar",
      "skip-github-release": true
    }
  },
  "plugins": [
    {
      "type": "node-workspace",
      "merge": false
    },
    {
      "type": "linked-versions",
      "groupName": "core",
      "components": [
        "@company/umbrella",
        "@company/foo",
        "@company/bar"
      ]
    }
  ]
}
  1. run release-please, it will generate release PR
  2. merge PR
  3. github release will be created, with the version tag @company/umbrella-v1.0.0
  4. release-please action will run the logic and will create release PR again, because for foo and bar it can not find release.

Notes:

  • There is one of the solutions that might work fix: linked-versions + includeComponentInTag=false should work #1749
  • Manual release tagging after release-please action wont help, because release PR created while action is still running
  • Separate action that can tag release after release creation might work, but for this private github token is needed and there is a possibility of race condition
@alex-enchi alex-enchi added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 27, 2023
@SurferJeffAtGoogle SurferJeffAtGoogle added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants