Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support generic updater #2227

Merged
merged 2 commits into from Mar 11, 2024
Merged

fix: Support generic updater #2227

merged 2 commits into from Mar 11, 2024

Conversation

regseb
Copy link
Contributor

@regseb regseb commented Feb 17, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2205 馃

@regseb regseb requested review from a team as code owners February 17, 2024 14:57
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Feb 17, 2024
@jyoder-deloitte
Copy link

Also addresses #2125. It might be nice to have a glob: true example as well.

Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late review.

We can adjust the json schema definition in a follow-up PR.

@chingor13 chingor13 merged commit 144c1fd into googleapis:main Mar 11, 2024
11 checks passed
@regseb regseb deleted the yaml branch March 12, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow forcing the use of the generic updater in extra-files
3 participants